[ 
https://issues.apache.org/jira/browse/METRON-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654546#comment-15654546
 ] 

ASF GitHub Bot commented on METRON-561:
---------------------------------------

GitHub user ottobackwards opened a pull request:

    https://github.com/apache/incubator-metron/pull/351

    METRON-561 the system property should override the sys env shell if set

    
    
    When running mvn integration-test , after having set EDITOR=vim in my 
.zshrc I see the following:
    
    Running org.apache.metron.management.ShellFunctionsTest
    
    Vim: Warning: Output is not to a terminal
    Vim: Warning: Input is not from a terminal
    
    And the tests never complete.
    
    The tests should run to completion and not count on system variables being 
configured the "right" way
    
    ---
    
    If the System.Property for EDITOR is set, then let that override the sys env

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/incubator-metron METRON-561

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #351
    
----
commit b1cf0825e91bcbed007b98cc5c2f396caaed5366
Author: Otto Fowler <[email protected]>
Date:   2016-11-10T16:59:07Z

    the system property should override the sys env shell if set

----


> ShellEditor tests hang if vim is set as EDITOR in your profile
> --------------------------------------------------------------
>
>                 Key: METRON-561
>                 URL: https://issues.apache.org/jira/browse/METRON-561
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.2.1BETA
>         Environment: zsh
> mac os x sierra
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>
> When running mvn integration-test , after having set EDITOR=vim in my .zshrc 
> I see the following: 
> Running org.apache.metron.management.ShellFunctionsTest
> Vim: Warning: Output is not to a terminal
> Vim: Warning: Input is not from a terminal
> And the tests never complete.
> The tests should run to completion and not count on system variables being 
> configured the "right" way



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to