[ 
https://issues.apache.org/jira/browse/METRON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677446#comment-15677446
 ] 

ASF GitHub Bot commented on METRON-575:
---------------------------------------

Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/362#discussion_r88715327
  
    --- Diff: 
metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java
 ---
    @@ -20,7 +20,18 @@
     
     package org.apache.metron.profiler.bolt;
     
    +import com.google.common.cache.Cache;
    +import com.google.common.cache.CacheBuilder;
    +import com.sun.tools.javac.jvm.Profile;
    --- End diff --
    
    Did you mean to include this?


> State from different profiles can be co-mingled incorrectly
> -----------------------------------------------------------
>
>                 Key: METRON-575
>                 URL: https://issues.apache.org/jira/browse/METRON-575
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Nick Allen
>            Assignee: Nick Allen
>
> The ProfileBuilderBolt incorrectly assumes that it will only ever see a 
> single [profile, entity] pair.  The bolt maintains a single StellarExecutor 
> that is responsible for executing the init, update, result expressions.  This 
> assumption is incorrect as Storm's field grouping only guarantees that the 
> same profile/entity pairs will go to the same task.  Storm does not guarantee 
> that a task only receives a single profile/entity pair.
> The easiest fix is to maintain a cache that maps a profile/entity to its 
> state.  This would follow what is currently done in the Join bolt. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to