[
https://issues.apache.org/jira/browse/METRON-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690664#comment-15690664
]
ASF GitHub Bot commented on METRON-578:
---------------------------------------
Github user justinleet commented on the issue:
https://github.com/apache/incubator-metron/pull/363
Looks like you could probably do it an easier way, by constructing
```
ProcessorResult.Builder<Map<String,List<JSONObject>>> builder = new
ProcessorResult.Builder();
return builder.withResult(messages).build();
```
more similar to
```
ProcessorResult.Builder<List<Map<String,Object>>> builder = new
ProcessorResult.Builder();
return
builder.withResult(docs).withProcessErrors(errors).withProcessInvalids(invalids).build();
```
That object already has fields for errors/invalids, and at that point you
can grab them separately from the output docs. Should avoid having to have the
messages the Map keyed by the topic.
What's there looks like it works (from a quick look), but using the results
builtin error/invalids is going to be a little more explicit about what's
happening and probably cleaner.
> Missing error handling bolts for enrichment and threat intel
> ------------------------------------------------------------
>
> Key: METRON-578
> URL: https://issues.apache.org/jira/browse/METRON-578
> Project: Metron
> Issue Type: Improvement
> Affects Versions: 0.2.1BETA
> Reporter: Justin Leet
> Assignee: Justin Leet
>
> TL;DR - we need to add error handling to enrichments/threat intel
> Metron has parsers, enrichment + threat intel, and indexing topologies
> currently. Parsers and and enrichment have bolts that write to error topics
> in Kafka
> # indexing_error
> # parser_error
> # parser_invalid
> The GenericEnrichmentBolt handles errors gracefully by passing along failed
> enrichment tuples un-enriched and additionally emitting the tuple to an
> "error" stream, however there is currently no plumbing to handle the error
> stream.
> {code:java}
> } catch (Exception e) {
> LOG.error("[Metron] Unable to enrich message: " + rawMessage, e);
> JSONObject error = ErrorUtils.generateErrorMessage("Enrichment problem:
> " + rawMessage, e);
> if (key != null) {
> collector.emit(enrichmentType, new Values(key, enrichedMessage,
> subGroup));
> }
> collector.emit("error", new Values(error));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
