[ 
https://issues.apache.org/jira/browse/METRON-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838548#comment-15838548
 ] 

ASF GitHub Bot commented on METRON-283:
---------------------------------------

Github user justinleet commented on the issue:

    https://github.com/apache/incubator-metron/pull/421
  
    Updated to replace `EnrichmentAdapter.initializeAdapter()` with 
`EnrichmentAdapter.initializeAdapter(Map<String, Object> config)`.  Also added 
`updateAdapter(Map<String, Object> config);`.  Right now the configs only get 
used by GeoAdapter, but all adapters can use configs it is passed as it needs.  
All implementing classes have the method updated, but simply ignore the config 
param.
    
    This removes the direct dependency of `GenericEnrichmentBolt` on 
`GeoLiteDatabase`.  It will simply call init and update to delegate to each 
adapter what to do (if anything).  Update is called during `reloadCallback` if 
global config updates.
    
    I'll want to spin it up again to further validate, but this addresses 
@nickwallen's catch on topologies not using geo needing geo data to exist and 
@dlyle65535's concern about the `GenericEnrichmentBolt` needing to know about 
geo for everything.  Now errors should only occur if a topology using geo data 
can't find it.


> Migrate Geo Enrichment outside of MySQL
> ---------------------------------------
>
>                 Key: METRON-283
>                 URL: https://issues.apache.org/jira/browse/METRON-283
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: James Sirota
>            Assignee: Justin Leet
>            Priority: Minor
>
> We need to migrate our enrichment SQL store from MySQL to Phoenix or some 
> other SQL on Hbase library.  Or alternatively come up with a way to do this 
> without using SQL.  This way we don't have a dependency on MySQL and there is 
> one less thing that we need to install on our platform 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to