[
https://issues.apache.org/jira/browse/METRON-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847583#comment-15847583
]
ASF GitHub Bot commented on METRON-658:
---------------------------------------
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/430
@nickwallen personally I don't think it should be a separate PR. To me it
is just one of those things that should be cleaned up as we go. My reasoning is
that I think we should encourage clean up as we go with minimal overhead.
However, I understand that it is difficult to read on github. I do agree that I
could have been more conscious of the way I made the commits though. I changed
this PR to have two commits,1 with the changes and 1 with the cleanup. If this
is still hard to review, I can split them into two PRs.
> Invalid Stellar Predicate Statement
> -----------------------------------
>
> Key: METRON-658
> URL: https://issues.apache.org/jira/browse/METRON-658
> Project: Metron
> Issue Type: Bug
> Reporter: Josh Meyer
> Labels: grammar, stellar
>
> Currently there seems to be an issue in the way Stellar defines predicate
> statements in its grammar. This may not necessarily be limited to predicate
> statements, but currently this is where the issue is showing itself. For
> example, the following expressions should be valid, but each of them fails
> during parsing.
> {code}
> ('grok' not in 'foobar') == true
> 'grok' not in ('foobar' == true)
> 'grok' not in 'foobar' == true
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
