[ 
https://issues.apache.org/jira/browse/METRON-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867981#comment-15867981
 ] 

ASF GitHub Bot commented on METRON-721:
---------------------------------------

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/456#discussion_r101297815
  
    --- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
    @@ -0,0 +1,40 @@
    +Thank you for submitting a contribution to Apache Metron (Incubating).
    +Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions
    +
    +In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check
    +the following:
    +
    +### For all changes:
    +- [ ] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel)
 
    +
    +- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    +
    +- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    +
    +
    +### For code changes:
    +- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    +- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
    +- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
    +
    +```
    +mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    +```
    +
    +- [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
    +- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    +
    +### For documentation related changes:
    +- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book?
    +
    +```
    +cd site-book
    +bin/generate-md.sh
    +mvn site:site
    +
    +view changes via target/site/index.html
    --- End diff --
    
    done



> Add Github pull request template to help submitters and reviewers
> -----------------------------------------------------------------
>
>                 Key: METRON-721
>                 URL: https://issues.apache.org/jira/browse/METRON-721
>             Project: Metron
>          Issue Type: Improvement
>         Environment: github
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>              Labels: github-pullrequest
>
> https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/
> A pull request template can be valuable in making sure that submitted pull 
> requests adhere to the requirements of the project.  
> Pull requests that come in up to standards can be reviewed and landed more 
> expediently



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to