[
https://issues.apache.org/jira/browse/METRON-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874970#comment-15874970
]
ASF GitHub Bot commented on METRON-503:
---------------------------------------
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/316#discussion_r102077984
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/SensorEnrichmentConfigController.java
---
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.rest.controller;
+
+import io.swagger.annotations.ApiOperation;
+import io.swagger.annotations.ApiParam;
+import io.swagger.annotations.ApiResponse;
+import io.swagger.annotations.ApiResponses;
+import
org.apache.metron.common.configuration.enrichment.SensorEnrichmentConfig;
+import org.apache.metron.rest.RestException;
+import org.apache.metron.rest.service.SensorEnrichmentConfigService;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.PathVariable;
+import org.springframework.web.bind.annotation.RequestBody;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RequestMethod;
+import org.springframework.web.bind.annotation.RestController;
+
+import java.util.List;
+import java.util.Map;
+
+@RestController
+@RequestMapping("/api/v1/sensor/enrichment/config")
+public class SensorEnrichmentConfigController {
+
+ @Autowired
+ private SensorEnrichmentConfigService sensorEnrichmentConfigService;
+
+ @ApiOperation(value = "Updates or creates a SensorEnrichmentConfig in
Zookeeper")
+ @ApiResponses(value = { @ApiResponse(message = "SensorEnrichmentConfig
updated. Returns saved SensorEnrichmentConfig", code = 200),
+ @ApiResponse(message = "SensorEnrichmentConfig created. Returns
saved SensorEnrichmentConfig", code = 201) })
+ @RequestMapping(value = "/{name}", method = RequestMethod.POST)
+ ResponseEntity<SensorEnrichmentConfig> save(@ApiParam(name="name",
value="SensorEnrichmentConfig name", required=true)@PathVariable String name,
+
@ApiParam(name="sensorEnrichmentConfig", value="SensorEnrichmentConfig",
required=true)@RequestBody SensorEnrichmentConfig sensorEnrichmentConfig)
throws RestException {
+ if (sensorEnrichmentConfigService.findOne(name) == null) {
+ return new ResponseEntity<>(sensorEnrichmentConfigService.save(name,
sensorEnrichmentConfig), HttpStatus.CREATED);
+ } else {
+ return new ResponseEntity<>(sensorEnrichmentConfigService.save(name,
sensorEnrichmentConfig), HttpStatus.OK);
+ }
+ }
+
+ @ApiOperation(value = "Retrieves a SensorEnrichmentConfig from
Zookeeper")
+ @ApiResponses(value = { @ApiResponse(message = "Returns
SensorEnrichmentConfig", code = 200),
+ @ApiResponse(message = "SensorEnrichmentConfig is missing", code
= 404) })
+ @RequestMapping(value = "/{name}", method = RequestMethod.GET)
+ ResponseEntity<SensorEnrichmentConfig> findOne(@ApiParam(name="name",
value="SensorEnrichmentConfig name", required=true)@PathVariable String name)
throws RestException {
+ SensorEnrichmentConfig sensorEnrichmentConfig =
sensorEnrichmentConfigService.findOne(name);
+ if (sensorEnrichmentConfig != null) {
+ return new ResponseEntity<>(sensorEnrichmentConfig, HttpStatus.OK);
+ }
+
+ return new ResponseEntity<>(HttpStatus.NOT_FOUND);
+ }
+
+ @ApiOperation(value = "Retrieves all SensorEnrichmentConfigs from
Zookeeper")
+ @ApiResponse(message = "Returns all SensorEnrichmentConfigs", code = 200)
+ @RequestMapping(method = RequestMethod.GET)
+ ResponseEntity<Map<String, SensorEnrichmentConfig>> getAll() throws
Exception {
--- End diff --
Bumping up the version to 0.3.1 resolved this.
> Metron REST API
> ---------------
>
> Key: METRON-503
> URL: https://issues.apache.org/jira/browse/METRON-503
> Project: Metron
> Issue Type: New Feature
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
> Attachments: Metron REST API.docx
>
>
> As discussed on the dev list ([DISCUSS] Metron REST API Requirements), this
> Jira includes adding a REST API to Metron.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)