[ https://issues.apache.org/jira/browse/METRON-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876698#comment-15876698 ]
ASF GitHub Bot commented on METRON-690: --------------------------------------- Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/450 @ottobackwards Yes, your observation is a good one. I wanted to toe the line between "obvious step-by-step" and "automated" and ended up on the side of "step-by-step obvious" because * I wanted people to be able to tinker and play with the steps to find things that I didn't * I didn't want to have to deal with weird one-off timing errors around some of the things specified here It's probably worth discussing acceptance testing scripts as a general category of testing that we might be able to do with some of these scripts forming the beginnings of them. > Create a DSL-based timestamp lookup for profiler to enable sparse windows > ------------------------------------------------------------------------- > > Key: METRON-690 > URL: https://issues.apache.org/jira/browse/METRON-690 > Project: Metron > Issue Type: New Feature > Reporter: Casey Stella > > I propose that we support the following features: > * A starting point that is not current time > * Sparse bins (i.e. the last hour for every tuesday for the last month) > * The ability to skip events (e.g. weekends, holidays) > This would result in a new function with the following arguments: > from - The lookback starting point (default to now) > fromUnits - The units for the lookback starting point > to - The ending point for the lookback window (default to from + binSize) > toUnits - The units for the lookback ending point > including - A list of conditions which we would skip. > weekend > holiday > sunday through saturday > excluding - A list of conditions which we would skip. > weekend > holiday > sunday through saturday > binSize - The size of the lookback bin > binUnits - The units of the lookback bin > Given the number of arguments and their complexity and the fact that many, > many are optional, > PROFILE_LOOKBACK accept a string backed by a DSL to express these criteria > Base Case: A lookback of 1 hour ago > PROFILE_LOOKBACK( '1 hour bins from now') > Example 1: The same time window every tuesday for the last month starting one > hour ago > Just to make this as clear as possible, if this is run at 3PM on Monday > January 23rd, 2017, it would include the following bins: > January 17th, 2PM - 3PM > January 10th, 2PM - 3PM > January 3rd, 2PM - 3PM > December 27th, 2PM - 3PM > PROFILE_LOOKBACK( '1 hour bins from 1 hour to 1 month including tuesdays') > Example 2: The same time window every sunday for the last month starting one > hour ago skipping holidays > Just to make this as clear as possible, if this is run at 3PM on Monday > January 22rd, 2017, it would include the following bins: > January 16th, 2PM - 3PM > January 9th, 2PM - 3PM > January 2rd, 2PM - 3PM > NOT December 25th > PROFILE_LOOKBACK( '1 hour bins from 1 hour to 1 month including tuesdays > excluding holidays') -- This message was sent by Atlassian JIRA (v6.3.15#6346)