[ 
https://issues.apache.org/jira/browse/METRON-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883072#comment-15883072
 ] 

ASF GitHub Bot commented on METRON-740:
---------------------------------------

GitHub user cestella opened a pull request:

    https://github.com/apache/incubator-metron/pull/464

    METRON-740: Normalizing and adding log4j properties override where possible.

    Add the ability to pass a log4j properties to MaaS CLI.
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check
    the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
    
    ```
    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    ```
    
    - [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
site-book/target/site/index.html.
    
    ```
    cd site-book
    bin/generate-md.sh
    mvn site:site
    
    ```
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommened that [travis-ci](https://travis-ci.org) is set up for 
your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cestella/incubator-metron METRON-740

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #464
    
----
commit d653a9b990a9c51d4c13dd8d5848a21624888ec9
Author: cstella <[email protected]>
Date:   2017-02-24T16:45:19Z

    Normalizing and adding log4j properties override where possible.

----


> Add the ability to pass a log4j properties to MaaS CLI
> ------------------------------------------------------
>
>                 Key: METRON-740
>                 URL: https://issues.apache.org/jira/browse/METRON-740
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>
> right now deploy and service CLI programs for MaaS do not allow the user to 
> override the log4j properties.  The flatfile loader does and MaaS should 
> follow suit.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to