[
https://issues.apache.org/jira/browse/METRON-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883226#comment-15883226
]
ASF GitHub Bot commented on METRON-741:
---------------------------------------
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/465
METRON-741: Stellar Field Transformations should execute all of the
transformations, not just the output
Stellar Field Transformations should execute all of the transformations,
not just the output.
Steps to reproduce:
* Create a parser called `dummy` with config
```
{
"parserClassName":"org.apache.metron.parsers.json.JSONMapParser",
"sensorTopic":"dummy",
"fieldTransformations" : [
{
"transformation" : "STELLAR"
,"output" : [ "final_value" ]
,"config" : {
"value1" : "1",
"value2" : "value1 + 1",
"final_value" : "value1 + value2"
}
}
]
}
```
* Push configs and start the parser
* Create the `dummy` kafka queue
* Send an empty map to the `dummy` kafka queue
* `echo "{}" |
/usr/hdp/current/kafka-broker/bin/kafka-console-producer.sh --broker-list
node1:6667 --topic dummy`
* Look at the output in elasticsearch
* `curl -XPOST 'http://localhost:9200/dummy*/_search?pretty'`
* Verify that
* `final_value` is there and it's 3
* `value1` and `value2` are not there.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check
the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
site-book/target/site/index.html.
```
cd site-book
bin/generate-md.sh
mvn site:site
```
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommened that [travis-ci](https://travis-ci.org) is set up for
your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron METRON-741
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/465.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #465
----
commit 1aad954bccefb61012ccb8f4aa6041f7eef90a45
Author: cstella <[email protected]>
Date: 2017-02-24T17:31:03Z
METRON-741: Stellar Field Transformations should execute all of the
transformations, not just the output
----
> Stellar Field Transformations should execute all of the transformations, not
> just the output
> --------------------------------------------------------------------------------------------
>
> Key: METRON-741
> URL: https://issues.apache.org/jira/browse/METRON-741
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
>
> Currently, the only stellar field transformations that are executed are those
> in the output field. We should execute all of the stellar statements in the
> order they are specified. Stellar statements which are not output may be
> used as intermediate variables for fields which are output.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
