[
https://issues.apache.org/jira/browse/METRON-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884528#comment-15884528
]
ASF GitHub Bot commented on METRON-742:
---------------------------------------
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/466
METRON-742: Generated code for profile window selector DSL did not get
committed as part of METRON-690
Lest we be concerned this implies that the testing done on 690 is voided,
this was due to the removal of the `NOW` lexical token, which was unused in the
grammar, along with a really dumb refactoring mistake changing "parse" to
"processing" that only hit generated code. The unit tests, etc. ran the code
in this PR since it was generated as part of the build.
This brings me to an interesting question that we might want to discuss.
Early on, we decided to submit generated code to ease potential issues around
pulling code into IDEs (generated code means we don't have to either remind
people to rerun `mvn generate-sources` or to instruct their IDEs to regenerate
sources automatically). Maybe we should revisit that point, but I don't know,
it's just a thought.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron METRON-742
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 57928349c9a5e0af9653c694672decc590b4e590
Author: cstella <[email protected]>
Date: 2017-02-26T04:32:02Z
METRON-742: Generated code for profile window selector DSL did not get
committed as part of METRON-690
----
> Generated code for profile window selector DSL did not get committed as part
> of METRON-690
> ------------------------------------------------------------------------------------------
>
> Key: METRON-742
> URL: https://issues.apache.org/jira/browse/METRON-742
> Project: Metron
> Issue Type: Bug
> Reporter: Casey Stella
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
