[
https://issues.apache.org/jira/browse/METRON-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884537#comment-15884537
]
ASF GitHub Bot commented on METRON-743:
---------------------------------------
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/467
METRON-743: Sort the files when reading results from Pcap
The FileSystem.listFiles() call does not return the files in sorted order,
which we assume for all FileSystem implementations. We should sort this to be
certain.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
site-book/target/site/index.html.
```
cd site-book
bin/generate-md.sh
mvn site:site
```
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommened that [travis-ci](https://travis-ci.org) is set up for
your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron METRON-743
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/467.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #467
----
commit 22ad59dd035489cd9ed3dbc60b6f54fcbf93ea0d
Author: cstella <[email protected]>
Date: 2017-02-26T04:53:54Z
METRON-743: Sort the files when reading results from Pcap
----
> Sort the files when reading results from Pcap
> ---------------------------------------------
>
> Key: METRON-743
> URL: https://issues.apache.org/jira/browse/METRON-743
> Project: Metron
> Issue Type: Bug
> Reporter: Casey Stella
>
> The FileSystem.listFiles() call does not return the files in sorted order,
> which we assume for all FileSystem implementations. We should sort this to
> be certain.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
