[
https://issues.apache.org/jira/browse/METRON-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899798#comment-15899798
]
ASF GitHub Bot commented on METRON-758:
---------------------------------------
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/474#discussion_r104725400
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/service/impl/HdfsServiceImplTest.java
---
@@ -65,6 +66,7 @@ public void listShouldListFiles() throws Exception {
FileUtils.writeStringToFile(new File(testDir, "file2.txt"),
"value2");
List<String> paths = hdfsService.list(new Path(testDir));
+ Collections.sort(paths, String::compareTo);
--- End diff --
This is nitpicky, but why even specify String::compareTo?
Collections.sort(paths) uses compareTo by default.
> HdfsServiceImplTest should sort files for list test
> ---------------------------------------------------
>
> Key: METRON-758
> URL: https://issues.apache.org/jira/browse/METRON-758
> Project: Metron
> Issue Type: Bug
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
>
> Similar to METRON-743, this test should sort files before asserting due to
> inconsistent sorting in FileSystem.listFiles.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
