[ 
https://issues.apache.org/jira/browse/METRON-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899949#comment-15899949
 ] 

ASF GitHub Bot commented on METRON-745:
---------------------------------------

GitHub user justinleet opened a pull request:

    https://github.com/apache/incubator-metron/pull/475

    METRON-745: Create Error Dashboards

    ## Summary
    Following Ryan's work in 
https://github.com/apache/incubator-metron/pull/453, we have the opportunity to 
present errors from our topologies.
    
    It's nothing too complicated, essentially just some high level overviews of 
the various error fields, along with a pane for viewing the actual errors along 
with all their fields.  Note that they include both raw and unique message 
counts (via the hash fields) in most things.
    
    This also corrects the error_index.template files.  These are supposed to 
match ErrorFields in Constants.java, but didn't.
    
    I've attached some screenshots, and this can be spun up on quick dev and 
Ambari (both dashboard.p and the various kibana-index.json are updated).  Quick 
dev automatically passes some data through, so it's a good way to get this spun 
up with something interesting showing.
    
    Feedback on what else would be useful and if we want to adjust anything 
would be great.  Keep in mind, we don't actually have a lot of fields to work 
with (because if everything was good, we wouldn't be here in the first place!). 
See error_index.template for the fields we have.
    
    ### Testing
    Spun up in quick-dev and Ambari.  Quick-dev will automatically put data 
through
    
    ### Notes
    * I'm really not convinced the 'hostname' visualizations are needed.  The 
field is there and useful, but given that it's populated with the Storm host 
that failed, it seems like it's probably useless most of the time.
    * Kibana occasionally rearranges the order of the visualizations (usually 
swapping a couple of the charts). 
     If I recall correctly, that's a known Kibana bug that we're stuck with.
    * Keep in mind the graph shifts by the viewing window.  So last 15 minutes 
vs last 7 days all updates accordingly.
    * This includes a fix to maps mentioned in 
https://github.com/apache/incubator-metron/pull/436.  If that PR goes in before 
this one, this PR should be take it's own copy of the dashboards.  If this PR 
goes in first, that PR should accept this one's dashboards.
    
    <img width="1440" alt="screen shot 2017-03-06 at 11 22 20 am" 
src="https://cloud.githubusercontent.com/assets/5077341/23672488/e5ae6c9a-033c-11e7-834d-caab26497f0e.png";>
    <img width="1440" alt="screen shot 2017-03-06 at 11 22 28 am" 
src="https://cloud.githubusercontent.com/assets/5077341/23672512/f3ceec5a-033c-11e7-946f-f7d279a4f3b0.png";>
    <img width="1439" alt="screen shot 2017-03-06 at 11 22 37 am" 
src="https://cloud.githubusercontent.com/assets/5077341/23672513/f58b317a-033c-11e7-8a21-b1a927971bba.png";>
    <img width="1439" alt="screen shot 2017-03-06 at 11 22 45 am" 
src="https://cloud.githubusercontent.com/assets/5077341/23672514/f6b6ee90-033c-11e7-9630-0143f2f31fcd.png";>
    
    
    
    The bottom pane extends further down, but we've all seen a table of data 
before.
    
    
    Thank you for submitting a contribution to Apache Metron (Incubating).
    Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.
    Please refer also to our [Build Verification 
guildlines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.
    
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check
    the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
    
    ```
    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    ```
    
    - [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
site-book/target/site/index.html.
    
    ```
    cd site-book
    bin/generate-md.sh
    mvn site:site
    
    ```
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommened that [travis-ci](https://travis-ci.org) is set up for 
your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/incubator-metron METRON-745

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/475.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #475
    
----
commit a517903fc40db05674edfb112016511a0da5be5c
Author: justinjleet <[email protected]>
Date:   2017-02-09T16:40:37Z

    Error dashboards + minor fixes

commit 0bf320fc407ed4d93d5326b862cb5c4a60576159
Author: justinjleet <[email protected]>
Date:   2017-03-07T15:10:52Z

    Updating to use the WMS compliant map server in Kibana to avoid issues with 
METRON-671

commit 68da4d9cb88bd3062a5fa1868152f94e95e1337f
Author: justinjleet <[email protected]>
Date:   2017-03-07T18:38:52Z

    Updating README

----


> Create Error Dashboards
> -----------------------
>
>                 Key: METRON-745
>                 URL: https://issues.apache.org/jira/browse/METRON-745
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>
> With errors being indexed once METRON-694 and the associated PR are pulled in 
> (https://github.com/apache/incubator-metron/pull/453), we should create 
> Kibana dashboards to be able to get some summary information and view the 
> errors we get.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to