[
https://issues.apache.org/jira/browse/METRON-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936419#comment-15936419
]
ASF GitHub Bot commented on METRON-793:
---------------------------------------
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/486#discussion_r107429992
--- Diff:
metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/deserializer/Deserializers.java
---
@@ -16,31 +16,35 @@
* limitations under the License.
*/
-package org.apache.metron.spout.pcap.scheme;
+package org.apache.metron.spout.pcap.deserializer;
-import org.apache.storm.spout.MultiScheme;
+import org.apache.metron.common.utils.timestamp.TimestampConverters;
import org.apache.metron.common.utils.timestamp.TimestampConverter;
-import org.apache.storm.kafka.KeyValueSchemeAsMultiScheme;
-public enum TimestampScheme {
- FROM_KEY( converter -> new KeyValueSchemeAsMultiScheme(new
FromKeyScheme().withTimestampConverter(converter)))
- ,FROM_PACKET(converter -> new
FromPacketScheme().withTimestampConverter(converter));
+import java.util.function.Function;
+
+public enum Deserializers {
--- End diff --
It's worth noting here that the new spout does not use multischemes. We
are doing a fair bit of byte munging on data coming into the pcap topology in
those multischemes, but the abstraction was clunky. This makes things a bit
clearer.
> Migrate to storm-kafka-client kafka spout from storm-kafka
> ----------------------------------------------------------
>
> Key: METRON-793
> URL: https://issues.apache.org/jira/browse/METRON-793
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
>
> In order to eventually support kerberos, the suggested path is to migrate to
> the new kafka spout (org.apache.storm:storm-kafka-client) which uses the new
> consumer API.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
