[
https://issues.apache.org/jira/browse/METRON-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940444#comment-15940444
]
ASF GitHub Bot commented on METRON-793:
---------------------------------------
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/486#discussion_r107913632
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyBuilder.java
---
@@ -106,19 +105,22 @@ public static TopologyBuilder build(String
zookeeperUrl,
/**
* Create a spout that consumes tuples from a Kafka topic.
*
- * @param zookeeperUrl Zookeeper URL
+ * @param zkQuorum Zookeeper URL
* @param sensorType Type of sensor
- * @param offset Kafka topic offset where the topology
will start; BEGINNING, END, WHERE_I_LEFT_OFF
- * @param kafkaSpoutConfigOptions Configuration options for the kafka
spout
+ * @param kafkaConfigOptional Configuration options for the kafka
spout
* @param parserConfig Configuration for the parser
* @return
*/
- private static KafkaSpout createKafkaSpout(String zookeeperUrl, String
sensorType, SpoutConfig.Offset offset, EnumMap<SpoutConfigOptions, Object>
kafkaSpoutConfigOptions, SensorParserConfig parserConfig) {
-
+ private static StormKafkaSpout createKafkaSpout(String zkQuorum, String
sensorType, Optional<Map<String, Object>> kafkaConfigOptional,
SensorParserConfig parserConfig) {
--- End diff --
StormKafkaSpout's return type here will actually be StormKafkaSpout<Object,
Object>, right? Can we make that explicit, rather than untyped (and also drop
the Object.class from the creates assuming the other typing change)?
> Migrate to storm-kafka-client kafka spout from storm-kafka
> ----------------------------------------------------------
>
> Key: METRON-793
> URL: https://issues.apache.org/jira/browse/METRON-793
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
>
> In order to eventually support kerberos, the suggested path is to migrate to
> the new kafka spout (org.apache.storm:storm-kafka-client) which uses the new
> consumer API.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
