[
https://issues.apache.org/jira/browse/METRON-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940580#comment-15940580
]
ASF GitHub Bot commented on METRON-623:
---------------------------------------
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/489#discussion_r107932789
--- Diff:
metron-interface/metron-config/src/app/general-settings/general-settings.component.spec.ts
---
@@ -0,0 +1,161 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import {Inject} from '@angular/core';
+import {async, TestBed, ComponentFixture} from '@angular/core/testing';
+import {Http} from '@angular/http';
+import {GeneralSettingsComponent} from './general-settings.component';
+import {MetronAlerts} from '../shared/metron-alerts';
+import {MetronDialogBox} from '../shared/metron-dialog-box';
+import {GlobalConfigService} from '../service/global-config.service';
+import {GeneralSettingsModule} from './general-settings.module';
+import {Observable} from 'rxjs/Observable';
+import {APP_CONFIG, METRON_REST_CONFIG} from '../app.config';
+import {IAppConfig} from '../app.config.interface';
+
+class MockGlobalConfigService extends GlobalConfigService {
+ _config: any = {};
+ _postSuccess: boolean = true;
+
+ constructor(private http2: Http, @Inject(APP_CONFIG) private config2:
IAppConfig) {
+ super(http2, config2);
+ }
+
+ public post(globalConfig: {}): Observable<{}> {
+ if (this._postSuccess) {
+ return Observable.create(observer => {
+ observer.next(globalConfig);
+ observer.complete();
+ });
+ }
+
+ return Observable.throw('Error');
+ }
+
+ public get(): Observable<{}> {
+ return Observable.create(observer => {
+ observer.next(this._config);
+ observer.complete();
+ });
+ }
+}
+
+describe('GeneralSettingsComponent', () => {
+
+ let metronAlerts: MetronAlerts;
+ let metronDialogBox: MetronDialogBox;
+ let component: GeneralSettingsComponent;
+ let globalConfigService: MockGlobalConfigService;
+ let fixture: ComponentFixture<GeneralSettingsComponent>;
+ let config = {
+ 'solr.collection': 'metron',
+ 'storm.indexingWorkers': 1,
+ 'storm.indexingExecutors': 2,
+ 'hdfs.boltBatchSize': 5000,
+ 'hdfs.boltFieldDelimiter': '|',
+ 'hdfs.boltFileRotationSize': 5,
+ 'hdfs.boltCompressionCodecClass':
'org.apache.hadoop.io.compress.SnappyCodec',
+ 'hdfs.indexOutput': '/tmp/metron/enriched',
+ 'kafkaWriter.topic': 'outputTopic',
+ 'kafkaWriter.keySerializer':
'org.apache.kafka.common.serialization.StringSerializer',
+ 'kafkaWriter.valueSerializer':
'org.apache.kafka.common.serialization.StringSerializer',
+ 'kafkaWriter.requestRequiredAcks': 1,
+ 'solrWriter.indexName': 'alfaalfa',
+ 'solrWriter.shards': 1,
+ 'solrWriter.replicationFactor': 1,
+ 'solrWriter.batchSize': 50,
+ 'fieldValidations': {'field': 'validation'}
+ };
+
+ beforeEach(async(() => {
+
+ TestBed.configureTestingModule({
+ imports: [GeneralSettingsModule],
+ providers: [
+ {provide: Http},
+ MetronAlerts,
+ MetronDialogBox,
+ {provide: GlobalConfigService, useClass: MockGlobalConfigService},
+ {provide: APP_CONFIG, useValue: METRON_REST_CONFIG}
+ ]
+ }).compileComponents()
+ .then(() => {
+ fixture = TestBed.createComponent(GeneralSettingsComponent);
+ component = fixture.componentInstance;
+ globalConfigService =
fixture.debugElement.injector.get(GlobalConfigService);
+ metronAlerts = fixture.debugElement.injector.get(MetronAlerts);
+ metronDialogBox =
fixture.debugElement.injector.get(MetronDialogBox);
+ });
+
+ }));
+
+ it('can instantiate GeneralSettingsComponent', async(() => {
+ expect(component instanceof GeneralSettingsComponent).toBe(true);
+ }));
+
+ it('should load global config', async(() => {
+ globalConfigService._config = config;
+ component.ngOnInit();
+
+ expect(component.globalConfig).toEqual(globalConfigService._config);
+ }));
+
+ it('should load save config', async(() => {
+ globalConfigService._config = config;
+ component.ngOnInit();
+ fixture.detectChanges();
+ spyOn(metronAlerts, 'showSuccessMessage');
+ spyOn(metronAlerts, 'showErrorMessage');
+
+ component.onSave();
+ expect(metronAlerts.showSuccessMessage).toHaveBeenCalledWith('Saved
Global Settings');
+
+ globalConfigService._postSuccess = false;
+
+ component.onSave();
+ expect(metronAlerts.showErrorMessage).toHaveBeenCalledWith('Unable to
save Global Settings: Error');
+
+ }));
+
+ it('should load save config', async(() => {
--- End diff --
duplicate test name
> Management UI
> -------------
>
> Key: METRON-623
> URL: https://issues.apache.org/jira/browse/METRON-623
> Project: Metron
> Issue Type: New Feature
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
>
> It would be useful to have a User Interface for modifying parser/enrichment
> configurations and managing topologies.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
