[
https://issues.apache.org/jira/browse/METRON-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953774#comment-15953774
]
ASF GitHub Bot commented on METRON-820:
---------------------------------------
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/508
METRON-820: StellarProcessor should have a static expression cache
## Contributor Comments
We recreate StellarProcessor objects all over the place which do not reuse
their expression caches. This results in a significant performance regression
as we are compiling the expression and then processing for every message,
rather than compiling once and reusing.
As far as testing, unit tests cover this functionality quite a bit. Also,
a smoke-test with vagrant is in order (i.e. ensuring data flows through the
topology) with a field transformation and a stellar enrichment set.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron (Incubating).
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
bin/generate-md.sh
mvn site:site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommened that [travis-ci](https://travis-ci.org) is set up for
your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron METRON-820
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/508.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #508
----
commit e5d41232faa523133ad91d8e56ab8ee38e467489
Author: cstella <ceste...@gmail.com>
Date: 2017-04-03T16:41:15Z
METRON-820: StellarProcessor should have a static expression cache
----
> StellarProcessor should have a static expression cache
> ------------------------------------------------------
>
> Key: METRON-820
> URL: https://issues.apache.org/jira/browse/METRON-820
> Project: Metron
> Issue Type: Bug
> Reporter: Casey Stella
>
> We recreate StellarProcessor objects all over the place which do not reuse
> their expression caches. This results in a significant performance
> regression as we are compiling the expression and then processing for every
> message, rather than compiling once and reusing.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
