[ 
https://issues.apache.org/jira/browse/METRON-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955779#comment-15955779
 ] 

ASF GitHub Bot commented on METRON-821:
---------------------------------------

GitHub user JonZeolla opened a pull request:

    https://github.com/apache/incubator-metron/pull/510

    METRON-821 Minor fixes in full dev kerberos setup instructions

    ## Contributor Comments
    As I ran through Kerberos-setup.md I found [one minor 
issue](https://github.com/apache/incubator-metron/blame/eb209f5c9400b81720a866ef5dd1817f73226f44/metron-deployment/vagrant/Kerberos-setup.md#L138),
 so I figured that if I was going to make a change I might as well make some 
other adjustments.  
    
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron (Incubating).  
    Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
    - [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:
    
      ```
      cd site-book
      bin/generate-md.sh
      mvn site:site
      ```
    Note:  I only reviewed the relevant 
`target/site/metron-deployment/vagrant/Kerberos-setup.html`
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JonZeolla/incubator-metron METRON-821

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/510.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #510
    
----
commit 5dd65bb30eccca25cb5b76a96a38af56f61139b8
Author: Jon Zeolla <zeo...@gmail.com>
Date:   2017-04-04T20:37:00Z

    Update Kerberos-setup.md documentation

commit f93c8e24aa840d0e61c90c1e88769a3278752108
Author: Jon Zeolla <zeo...@gmail.com>
Date:   2017-04-04T20:43:21Z

    This typo has been driving me crazy

----


> Minor fixes in full dev kerberos setup instructions
> ---------------------------------------------------
>
>                 Key: METRON-821
>                 URL: https://issues.apache.org/jira/browse/METRON-821
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Jon Zeolla
>            Assignee: Jon Zeolla
>
> There is at least one error in metron-deployment/vagrant/Kerberos-setup.md 
> and some other very minor changes for clarity/accuracy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to