[
https://issues.apache.org/jira/browse/METRON-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957074#comment-15957074
]
ASF GitHub Bot commented on METRON-827:
---------------------------------------
GitHub user mmiklavc opened a pull request:
https://github.com/apache/incubator-metron/pull/513
METRON-827: Fix full dev build dependency multi-threading issue with maven
Addresses https://issues.apache.org/jira/browse/METRON-827
I was experiencing issues spinning up full dev 2x in a row. The observed
behavior was for me to see old code deployed in RPMs the first run, and no RPMs
in the build output or in /localrepo on the VM during the second run. I believe
this may have been a race condition introduced when we added `-T 2C` for
multi-threading the build to the "build metron artifacts" Ansible task. Since
the projects had no explicit dependency, the ordering may not have been
consistent from run to run and machine to machine. To address this, I've added
pom dependencies for the metron-deployment project on metron-platform and
metron-analytics.
Test by spinning up full-dev.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron (Incubating).
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
NA
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommened that [travis-ci](https://travis-ci.org) is set up for
your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/incubator-metron METRON-827
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #513
----
commit 29d798a2cd5bfa092db617ce64ce59de44556ca1
Author: Michael Miklavcic <michael.miklav...@gmail.com>
Date: 2017-04-05T15:38:29Z
METRON-827: Fix full dev build dependency multi-threading issue with maven
----
> Fix full dev build dependency multi-threading issue with maven
> --------------------------------------------------------------
>
> Key: METRON-827
> URL: https://issues.apache.org/jira/browse/METRON-827
> Project: Metron
> Issue Type: Bug
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
>
> The full-dev build will sporadically fail to run correctly because of
> possible race conditions with the Maven reactor.
> Without a dependency on metron-platform and metron-analytics, the following
> command may run the mpack and rpm builds while the rest of Metron is still
> being built.
> mvn clean package -DskipTests -T 2C -P HDP-2.5.0.0,mpack,build-rpms
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
