[
https://issues.apache.org/jira/browse/METRON-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957701#comment-15957701
]
ASF GitHub Bot commented on METRON-826:
---------------------------------------
GitHub user dlyle65535 opened a pull request:
https://github.com/apache/incubator-metron/pull/515
METRON-826: Ambari MPack should utilize service specific repos
## Contributor Comments
This change moves us away from the (as of
[AMBARI-15538|https://issues-test.apache.org/jira/browse/AMBARI-15538])
non-standard practice of creating repo files in the install methods.
To test, run this up on full dev- in addition to a running Metron, you
should see the following repos created in /etc/yum.repos.d
- METRON.repo
- ELASTICSEARCH.repo
- CURATOR.repo
- KIBANA.repo
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron (Incubating).
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [X] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [X] Have you included steps or a guide to how the change may be verified
and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [X] Have you written or updated unit tests and or integration tests to
verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [N/A] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
bin/generate-md.sh
mvn site:site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dlyle65535/incubator-metron METRON-826
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/515.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #515
----
----
> Ambari MPack should utilize service specific repos
> --------------------------------------------------
>
> Key: METRON-826
> URL: https://issues.apache.org/jira/browse/METRON-826
> Project: Metron
> Issue Type: Improvement
> Reporter: David M. Lyle
> Assignee: David M. Lyle
>
> Ambari 2.4.2 introduced a notion of [service specific
> repos|https://issues-test.apache.org/jira/browse/AMBARI-15538]. Rather than
> carry our [setup repo|
> https://github.com/apache/incubator-metron/blob/master/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py#L77
> ] method, use a repoinfo.xml definition file.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
