[ 
https://issues.apache.org/jira/browse/METRON-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960048#comment-15960048
 ] 

ASF GitHub Bot commented on METRON-830:
---------------------------------------

Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/516#discussion_r110293191
  
    --- Diff: 
metron-platform/metron-common/src/test/java/org/apache/metron/common/dsl/functions/StringFunctionsTest.java
 ---
    @@ -207,4 +207,78 @@ public void testFormatWithNoArguments() throws 
Exception {
       public void testFormatWithMissingArguments() throws Exception {
         run("FORMAT('missing arg: %d')", Collections.emptyMap());
       }
    +
    +
    +  /**
    +  * CHOP StringFunction
    +  * @throws Exception
    +  */
    +  @Test
    +  public void testChop() throws Exception {
    +    Assert.assertEquals("ab",   run("CHOP('abc')", new HashedMap()));
    +    Assert.assertEquals(null,   run("CHOP(null)", new HashedMap()));
    +    Assert.assertEquals("abc",  run("CHOP(msg)", ImmutableMap.of("msg", 
"abc\r\n")));
    --- End diff --
    
    Why does this work, when the string "abc\r\n" is never processed by any of 
the shell or java string input processors that might convert it?


> Adding StringFunctions to Stellar - chop, prependifmissing, appendifmissing 
> and countmatches
> --------------------------------------------------------------------------------------------
>
>                 Key: METRON-830
>                 URL: https://issues.apache.org/jira/browse/METRON-830
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.3.1
>            Reporter: Anand Subramanian
>            Assignee: Anand Subramanian
>             Fix For: Next + 1
>
>
> Enhance Stellar by adding the following apache common string functions.
> - chop -> Remove the last character from a String.
> - prependifmissing -> Prepends the prefix to the start of the string if the 
> string does not already start with any of the prefixes.
> - appendifmissing -> Appends the suffix to the end of the string if the 
> string does not already end with any of the suffixes.
> - countmatches -> Counts how many times the substring appears in the larger 
> string.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to