[ 
https://issues.apache.org/jira/browse/METRON-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960756#comment-15960756
 ] 

ASF GitHub Bot commented on METRON-799:
---------------------------------------

Github user dlyle65535 commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/518#discussion_r110384006
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py
 ---
    @@ -72,55 +93,46 @@ def remote_repo():
                 raise ValueError("Unsupported repo type 
'{0}'".format(repo_type))
     
         def init_kafka_topics(self):
    -        Logger.info('Creating Kafka topics')
    -        command_template = """{0}/kafka-topics.sh \
    -                                --zookeeper {1} \
    -                                --create \
    -                                --topic {2} \
    -                                --partitions {3} \
    -                                --replication-factor {4} \
    -                                --config retention.bytes={5}"""
    -        num_partitions = 1
    -        replication_factor = 1
    -        retention_gigabytes = int(self.__params.metron_topic_retention)
    -        retention_bytes = retention_gigabytes * 1024 * 1024 * 1024
    -        Logger.info("Creating topics for indexing")
    -
    -        Logger.info("Creating topic'{0}'".format(self.__indexing))
    -        Execute(command_template.format(self.__params.kafka_bin_dir,
    -                                        self.__params.zookeeper_quorum,
    -                                        self.__indexing,
    -                                        num_partitions,
    -                                        replication_factor,
    -                                        retention_bytes))
    -        Logger.info("Done creating Kafka topics")
    +        Logger.info('Creating Kafka topics for indexing')
    +        metron_service.init_kafka_topics(self.__params, [self.__indexing])
    +
    +    def init_kafka_acls(self):
    +        Logger.info('Creating Kafka ACLs')
    +        # Indexed topic names matches the group
    +        metron_service.init_kafka_acls(self.__params, [self.__indexing], 
[self.__indexing])
     
         def init_hdfs_dir(self):
    -        Logger.info('Creating HDFS indexing directory')
    +        Logger.info('Setting up HDFS indexing directory')
    +
    +        # Non Kerberized Metron runs under 'storm', requiring write under 
the 'hadoop' group.
    +        # Kerberized Metron runs under it's own user.
    +        ownership = 0755 if self.__params.security_enabled else 0775
    +        Logger.info('HDFS indexing directory ownership is: ' + 
str(ownership))
             
self.__params.HdfsResource(self.__params.metron_apps_indexed_hdfs_dir,
                                        type="directory",
                                        action="create_on_execute",
                                        owner=self.__params.metron_user,
                                        group=self.__params.hadoop_group,
    --- End diff --
    
    Did you intend to leave this as hadoop group ownership or change it to the 
metron group?


> The MPack should function in a kerberized cluster
> -------------------------------------------------
>
>                 Key: METRON-799
>                 URL: https://issues.apache.org/jira/browse/METRON-799
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>            Assignee: Justin Leet
>              Labels: kerberos
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to