[ 
https://issues.apache.org/jira/browse/METRON-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964844#comment-15964844
 ] 

ASF GitHub Bot commented on METRON-830:
---------------------------------------

Github user anandsubbu commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/516#discussion_r110992116
  
    --- Diff: metron-platform/metron-common/README.md ---
    @@ -167,6 +172,14 @@ The `!=` operator is the negation of the above.
     | [ `WEEK_OF_YEAR`](#week_of_year)                                         
                          |
     | [ `YEAR`](#year)                                                         
                          |
     
    +### `APPEND_IF_MISSING`
    +  * Description: Appends the suffix to the end of the string if the string 
does not already end with any of the suffixes.
    +  * Input:
    +    * string - The string to be appended.
    +    * suffix - The string suffix to append to the end of the string.
    +    * suffixes - Optional - Additional string suffixes that are valid 
terminators.
    --- End diff --
    
    Hi @mattf-horton , I was trying to following the same wording as the 
[apache commons 
documentation](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html)
 for PrependIfMissing, which uses the plural form. 
    
    Let me know if it would be better if I changed the text as follows:
    
    `* suffix - The string suffix to append to the end of the string.`
    `* additionalsuffix - Optional - An additional string suffix that is a 
valid terminator.`


> Adding StringFunctions to Stellar - chop, prependifmissing, appendifmissing 
> and countmatches
> --------------------------------------------------------------------------------------------
>
>                 Key: METRON-830
>                 URL: https://issues.apache.org/jira/browse/METRON-830
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.3.1
>            Reporter: Anand Subramanian
>            Assignee: Anand Subramanian
>             Fix For: Next + 1
>
>
> Enhance Stellar by adding the following apache common string functions.
> - chop -> Remove the last character from a String.
> - prependifmissing -> Prepends the prefix to the start of the string if the 
> string does not already start with any of the prefixes.
> - appendifmissing -> Appends the suffix to the end of the string if the 
> string does not already end with any of the suffixes.
> - countmatches -> Counts how many times the substring appears in the larger 
> string.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to