[ 
https://issues.apache.org/jira/browse/MXNET-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389784#comment-16389784
 ] 

ASF GitHub Bot commented on MXNET-33:
-------------------------------------

ashokei commented on a change in pull request #10021: [MXNET-33] Mkldnn pooling 
convention crash
URL: https://github.com/apache/incubator-mxnet/pull/10021#discussion_r172909508
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h
 ##########
 @@ -92,6 +92,8 @@ inline bool SupportMKLDNNPooling(const PoolingParam &param,
 
   if (param.pooling_convention == pool_enum::kValid)
     return true;
+  else
+    return false;
 
 Review comment:
   @piiswrong the later code is being disabled for now until we support all 
"full" pooling convention cases.  As @TaoLv mentioned, i will add a unit-test 
for this failure. 
   We may refactor this code, so marking this PR WIP for now.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> mxnet mkl-dnn crashes for Max pooling with convention "full" 
> -------------------------------------------------------------
>
>                 Key: MXNET-33
>                 URL: https://issues.apache.org/jira/browse/MXNET-33
>             Project: Apache MXNet
>          Issue Type: Bug
>            Reporter: Ashok Emani
>            Assignee: Chris Olivier
>            Priority: Minor
>
> A crash is seen when running SSD-VGG16 300 VOC , with mxnet mkldnn build, for 
> the following op.
>  
> "op": "Pooling",                            
> "attrs": {                     
>   "kernel": "(2, 2)",          
>   "pool_type": "max",          
>   "pooling_convention": "full",
>   "stride": "(2, 2)"           
> },    
>                       



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org

Reply via email to