[
https://issues.apache.org/jira/browse/MXNET-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410896#comment-16410896
]
Tao Lv commented on MXNET-98:
-----------------------------
https://github.com/intel/mkl-dnn/commit/8758fe6ec8a1695b6ac1570b749818a188d0ad66
A PR for this issue is merged to mkldnn master branch. We can add unit test to
mxnet when we update mkldnn version in mxnet next time.
> Need add unit-test to monitor data format change of MKL-DNN
> -----------------------------------------------------------
>
> Key: MXNET-98
> URL: https://issues.apache.org/jira/browse/MXNET-98
> Project: Apache MXNet
> Issue Type: Test
> Reporter: Tao Lv
> Priority: Minor
>
> Since we have built a
> [mapping|https://github.com/apache/incubator-mxnet/blob/master/src/operator/nn/mkldnn/mkldnn_base.cc#L193]
> from MKL-DNN data format to MXNet default data format, say mkldnn_nChw8c and
> mkldnn_nChw16c will both map to nchw. If new data format is added to MKL-DNN,
> this kind of mapping will be broken. We need set a dedicated unit-test to
> monitor the change of MKL-DNN data format. If the test case fails, we should
> check this piece of code to see if we need adjust it to handle new data
> format properly.
> Since MKL-DNN lists all supported data formats in an enum type. It's a little
> difficult to monitor the change of enum type at mxnet side. We have asked
> MKL-DNN team to add support for that. Will finish this unit-test after
> getting response from MKL-DNN team.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
