Junru Shao created MXNET-1403:
---------------------------------
Summary: Disable numpy's writability of NDArray once it is
zero-copied to MXNet
Key: MXNET-1403
URL: https://issues.apache.org/jira/browse/MXNET-1403
Project: Apache MXNet
Issue Type: Improvement
Reporter: Junru Shao
|h2. Description
Per discussion with [@szha|https://github.com/szha] , we decided that we do not
allow ndarrays to be manipulated on the numpy side to ensure correctness.h2.
Checklisth3. Essentials
Please feel free to remove inapplicable items for your PR. * The PR title
starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA
issue|https://issues.apache.org/jira/projects/MXNET/issues] created (except PRs
with tiny changes)
* Changes are complete (i.e. I finished coding on this PR)
* All changes have test coverage:
* Unit tests are added for small changes to verify correctness (e.g. adding a
new operator)
* Nightly tests are added for complicated/long-running ones (e.g. changing
distributed kvstore)
* Build tests will be added for build configuration changes (e.g. adding a new
build option with NCCL)
* Code is well-documented:
* For user-facing API changes, API doc string has been updated.
* For new C++ functions in header files, their functionalities and arguments
are documented.
* For new examples, README.md is added to explain the what the example does,
the source of the dataset, expected performance on test set and reference to
the original paper if applicable
* Check the API doc at
[http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html]
* To the my best knowledge, examples are either not affected by this change,
or have been fixed to be compatible with this change
h3. Changes * Set up writable flags to be False.
h2. Comments
None|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
