samskalicky commented on issue #19135: URL: https://github.com/apache/incubator-mxnet/issues/19135#issuecomment-691728389
In previous 1.x releases we're been terribly inconsistent: - 1.6.0 didnt have a `MX_LIBRARY_VERSION` number: https://github.com/apache/incubator-mxnet/blob/1.6.0/include/mxnet/lib_api.h#L25-L33 - 1.7.0 had version number 7: https://github.com/apache/incubator-mxnet/blob/1.7.0/include/mxnet/lib_api.h#L52 - 1.8.0 will have version number 10: https://github.com/apache/incubator-mxnet/blob/35feed663427ceafd3369a55c47d7140476851ea/include/mxnet/lib_api.h#L56 From 1.7 we're consistently checking the version number at least. Lets focus the discussion on how to do things better for 2.0. We'll probably need to keep the version number (to avoid backward incompatible libraries from earlier versions). But I guess we can stop incrementing it for minor releases and do as you suggest on API changes to enable backwards compatibility for 2.x minor versions. And then in major version changes we can increment the version number to demarcate backward incompatibility. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
