leezu commented on issue #19255: URL: https://github.com/apache/incubator-mxnet/issues/19255#issuecomment-704591419
> It seems like for the issue reported, it would be simple to test for and ignore the 'Skipped' exception. Do you have a problem with that as an easy incremental fix? Yes, it's fine to add special handling for the `Skipped` exception. As we also have the "issue" of executing the seeding stage twice for every test function (once via the pytest seed fixture and another time via the `@with_seed` decorator), another solution (with more effort) would be removing `@with_seed` and using the pytest fixture (which was originally derived from the `@with_seed` decorator for the GluonNLP project). > Also, with my brief exposure to pytest-repeat, I experienced a non-linear runtime expansion with the use of --count, making useful values like 1000 unworkable. Have you seen that? I haven't seen that but must admit that I haven't played much with pytest-repeat. The implementation is relatively short though https://github.com/pytest-dev/pytest-repeat/blob/9b71e7ffb335b15765bc315220b0950dafcc86ec/pytest_repeat.py#L51-L70 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
