mk-61 commented on issue #18697: URL: https://github.com/apache/incubator-mxnet/issues/18697#issuecomment-724958074
Hi @szha, why do you want to implement AMP with a graph pass? Which aspects of the current approach do you expect to improve by switching to a graph pass? One drawback of the Python-side monkey patching I see is that it is sensitive to how various ops are registered on the client side - NumPy vs legacy, imperative vs hybridized, etc. - ideally, we want to handle this in a uniform way, since we don't really care about these distinctions, as far as AMP itself is concerned. But I am curious if you have some other deficiencies of the current approach in mind. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
