szha commented on issue #20066: URL: https://github.com/apache/incubator-mxnet/issues/20066#issuecomment-809713535
cudnnDataType_t doesn't come from mxnet and it doesn't support int16. I haven't looked into the exact request, so the following comment is about adding new dtype in general. Adding a new dtype involves several steps, including: - Adding the dtype definition: https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/3rdparty/mshadow/mshadow/base.h#L352-L366 - Adding support in the desired operator. Lots of the operators in MXNet use macros for supporting multiple data types: https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/src/operator/mxnet_op.h#L198-L241 - Adding option for operators that take explicit dtype. https://github.com/apache/incubator-mxnet/blob/66a65924f03e6e62ca0619afb02e2a674fcccbfd/src/operator/random/sample_op.h#L103-L105 - Adding frontend support for the dtype: https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/python/mxnet/numpy/utils.py#L24-L55 https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/python/mxnet/ndarray/ndarray.py#L65-L112 - Adding dlpack support. https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/python/mxnet/dlpack.py#L46-L60 - Test for the new dtype. https://github.com/apache/incubator-mxnet/blob/5722f8b38af58c5a296e46ca695bfaf7cff85040/tests/python/unittest/test_numpy_ndarray.py#L38-L53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
