[
https://issues.apache.org/jira/browse/NIFI-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367190#comment-15367190
]
ASF GitHub Bot commented on NIFI-826:
-------------------------------------
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/617
@mcgilman @jtstorck could you please look at the second commit where I had
to ignore two Spoke tests. Basically two issues there.
1. Components are created without ID. With new code changes it now results
in NPE (I can provide more details, but basically
```
new ProcessorDTO(position: new PositionDTO(x: 10, y: 10))]
```
should be something like
```
new ProcessorDTO(id:"c81f6810-0155-1000-0000-c4af042cb1559", position: new
PositionDTO(x: 10, y: 10))]
```
While the above is easy, those tests are now failing due to me commenting
the positioning logic (see previous comment). so we need to come up with the
plan as to what needs to be done properly or what I've done is sifficient.
> Export templates in a deterministic way
> ---------------------------------------
>
> Key: NIFI-826
> URL: https://issues.apache.org/jira/browse/NIFI-826
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Matt Gilman
> Assignee: Oleg Zhurakousky
> Fix For: 1.0.0
>
>
> Templates should be exported in a deterministic way so that they can be
> compared or diff'ed with another. Items to consider...
> - The ordering of components
> - The id's used to identify the components
> - Consider excluding irrelevant items. When components are imported some
> settings are ignored (run state).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)