[
https://issues.apache.org/jira/browse/NIFI-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370575#comment-15370575
]
ASF GitHub Bot commented on NIFI-2147:
--------------------------------------
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/620#discussion_r70240401
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js
---
@@ -1328,9 +1328,9 @@
var tooltip =
nf.Common.formatPropertyTooltip(propertyDescriptor, propertyHistory);
if (nf.Common.isDefinedAndNotNull(tooltip)) {
- infoIcon.qtip($.extend({
- content: tooltip,
- }, nf.Common.config.tooltipConfig));
+ infoIcon.qtip($.extend(nf.Common.config.tooltipConfig,
{
--- End diff --
@scottyaslan - If you checkout the description of $.extend [1] it shows the
first argument is the target meaning that is what object that is being
modified/updated. I don't we want to be modifying the tooltip configuration
template like we are here as it will affect all subsequent $.extend calls.
This applies to all of modified $.extend lines in this PR.
[1] https://api.jquery.com/jquery.extend/
> Warning/Invalid roll-over text is cut-off
> -----------------------------------------
>
> Key: NIFI-2147
> URL: https://issues.apache.org/jira/browse/NIFI-2147
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
> Affects Versions: 1.0.0
> Environment: Mac OS X, Chrome
> Reporter: Andrew Lim
> Assignee: Scott Aslan
> Priority: Minor
> Labels: UI
> Fix For: 1.0.0
>
> Attachments: NIFI-2147_ControllerServices.png,
> NIFI-2147_ReportingTasks.png
>
>
> As shown in the attached screenshots, the user is not able to see the
> complete text of why the controller service or reporting task is invalid.
> Looks like the text is centered on the warning icon, but should be left
> justified.
> Similarly for the Process Group Configuration
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
