Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/625
@apsaltis very cool that you were able to jump in and knock this out! The
community very much appreciates it! Looking through the code, it all looks
good. I did notice though that the client library was changed, and the
licensing information was not updated. Need to be sure that the NOTICE file in
both the nar's src/main/resources directory as well as the nifi-assembly's
NOTICE file. The previous client used an ASF 2.0 license, and the new one uses
an MIT license.
Also, I did notice that the Put could be more efficient by sending several
events asynchronously and then waiting on the ACK's to come back. I created a
new JIRA for this though (https://issues.apache.org/jira/browse/NIFI-2220)
because it's not necessarily critical to get that into this PR.
If you can update the LICENSE info, then I should be able to get this
merged in.
Thanks again for knocking this out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
