[
https://issues.apache.org/jira/browse/NIFI-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370735#comment-15370735
]
ASF GitHub Bot commented on NIFI-2214:
--------------------------------------
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/625
@apsaltis very cool that you were able to jump in and knock this out! The
community very much appreciates it! Looking through the code, it all looks
good. I did notice though that the client library was changed, and the
licensing information was not updated. Need to be sure that the NOTICE file in
both the nar's src/main/resources directory as well as the nifi-assembly's
NOTICE file. The previous client used an ASF 2.0 license, and the new one uses
an MIT license.
Also, I did notice that the Put could be more efficient by sending several
events asynchronously and then waiting on the ACK's to come back. I created a
new JIRA for this though (https://issues.apache.org/jira/browse/NIFI-2220)
because it's not necessarily critical to get that into this PR.
If you can update the LICENSE info, then I should be able to get this
merged in.
Thanks again for knocking this out!
> Convert Azure Event Hub Processors to use correct Azure Event Hub client
> library
> --------------------------------------------------------------------------------
>
> Key: NIFI-2214
> URL: https://issues.apache.org/jira/browse/NIFI-2214
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Andrew Psaltis
> Fix For: 1.0.0
>
>
> Currently NiFi uses the Event Hub client found here:
> https://github.com/hdinsight/eventhubs-client/ however, it should use the
> client library found here:
> https://github.com/Azure/azure-event-hubs/tree/master/java
>
> The Azure Event Hub client targets JDK 1.8 and therefore, the resolution of
> this JIRA is only applicable to NiFi 1.0.0 or later.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
