[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373434#comment-15373434
 ] 

ASF GitHub Bot commented on NIFI-1838:
--------------------------------------

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/534#discussion_r70496787
  
    --- Diff: 
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
 ---
    @@ -92,11 +92,10 @@
                         logger.error(message, t);
                     }
                 }
    -        } else {
    -            // Return defaults for now
    -            relationships.add(REL_SUCCESS);
    -            relationships.add(REL_FAILURE);
             }
    +        // Add defaults
    +        relationships.add(REL_SUCCESS);
    +        relationships.add(REL_FAILURE);
    --- End diff --
    
    @PuspenduBanerjee it looks like the current behavior is correct and as 
intended as @pvillard31 and @mattyb149 appear to be stating.  If that is true, 
it looks like the bug here is the documentation.  @mattyb149 please confirm.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> ----------------------------------------------------------------------
>
>                 Key: NIFI-1838
>                 URL: https://issues.apache.org/jira/browse/NIFI-1838
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.0.0, 0.6.1
>            Reporter: Puspendu Banerjee
>              Labels: patch
>             Fix For: 1.0.0
>
>         Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to