[ 
https://issues.apache.org/jira/browse/NIFI-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373898#comment-15373898
 ] 

Joseph Witt commented on NIFI-1152:
-----------------------------------

[[email protected]] I'd like to apologize as I now more fully 
understand what you were facing and I see why you did NIFI-1152 and NIFI-2117 
together - you were definitely on the right track.  I'll have a new PR in later 
this evening hopefully that addresses NIFI-1152 and NIFI-2117 together because 
as you probably found fixing NIFI-1152 reveals a bug in NIFI-2117.  Fortunately 
this event has led to finding the root problem which was a bug in 
StandardProcessSession as it was not honoring API definitions which is now 
fixed, the mock session has been fixed, and we'll get the invoke script sorted 
as you found.

[~mattyb149]  Would love to hear your intent for SUCCESS and FAILURE on 
InvokeScriptedProcessor.  You have code which suggests you only want 
success/failure relationships there if no other relationships have been 
provided by the invoked script.  But, as Puspendu rightly points out the 
javadocs state they'll always be there.  I think on balance we need to probably 
make them always available and take the migration hit that might occur.  It 
will only make flows invalid and need relationships added worst case - won't 
break behavior so is ok.  But please confirm.

Once this PR is sorted then the groovy tests can be addressed if that is a 
problem and so long as I don't find that one has to be in here too!

Thanks
Joe

> StandardProcessSession and MockProcessSession should handle transfer to 
> unregistered relationship correctly
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-1152
>                 URL: https://issues.apache.org/jira/browse/NIFI-1152
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Tools and Build
>    Affects Versions: 1.0.0, 0.6.0, 0.7.0, 0.6.1
>            Reporter: Mark Payne
>            Assignee: Joseph Witt
>              Labels: beginner, newbie
>             Fix For: 1.0.0
>
>         Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> If a processor calls ProcessSession.transfer(flowFile, 
> NON_EXISTENT_RELATIONSHIP) the NiFi framework will throw a 
> FlowFileHandlingException. However, the Mock Framework simply allows it and 
> does not throw any sort of Exception. This needs to be addressed so that the 
> Mock framework functions the same way as the normal NiFi framework.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to