Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/575#discussion_r70831015
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
 ---
    @@ -1004,7 +1004,7 @@ public ProcessorNode createProcessor(final String 
type, String id, final boolean
                 creationSuccessful = false;
             }
     
    -        final ValidationContextFactory validationContextFactory = new 
StandardValidationContextFactory(controllerServiceProvider);
    +        final ValidationContextFactory validationContextFactory = new 
StandardValidationContextFactory(controllerServiceProvider, this);
    --- End diff --
    
    I really don't like passing the FlowController itself. Why can't it just 
pass the value? Or if it needs to be able to be updated, it could pass a shared 
reference.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to