[
https://issues.apache.org/jira/browse/NIFI-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379560#comment-15379560
]
Joseph Witt commented on NIFI-2194:
-----------------------------------
+1 merged to master.
The improved documentation is very helpful. The cached JSON is a potential
concern as far as memory usage on really large flows. Might be worth flagging
that for follow up action should that concern be worthy.
clean build w/contrib check solid.
thanks
> AmbariReportingTask should cache metrics
> ----------------------------------------
>
> Key: NIFI-2194
> URL: https://issues.apache.org/jira/browse/NIFI-2194
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 0.6.1
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Minor
> Fix For: 1.0.0
>
>
> The Ambari Metrics Collector expects clients to perform some amount of
> caching/aggregation before sending metrics. This is typically done by using
> the TimelineMetricsCache provided in ambari-commons. The AmbariReportingTask
> should use this to properly send metrics.
> In addition many applications sending metrics extend
> AbstractTimelineMetricsSink [1]. It is not required to do so, but may be
> useful here.
> [1]
> https://github.com/apache/ambari/blob/trunk/ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
