Github user JPercivall commented on the issue:

    https://github.com/apache/nifi/pull/655
  
    Hello @Ramizjon, I'm gonna review this for you. Couple admin things to 
start.
    
    First, the versions of the datadog poms are "0.6.1". These should be 
changed to "1.0.0-SNAPSHOT". Second, the datadog bundle should be listed in the 
nifi-nar-bundle pom as a module. Also the classes you create should have the 
ASF license at the top. 
[Here](https://github.com/apache/nifi/blob/c3d54ab7246fba5ea1432d949c79f97f0e97f25c/nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/GetKafka.java#L1-L1)
 is an example. The offending files are listed below. Lastly the nar should 
include a License in addition to the notice.
    
    
    Unapproved licenses:
    
      
/Users/jpercivall/projects/nifi/nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/DataDogReportingTask.java
      
/Users/jpercivall/projects/nifi/nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/DDMetricRegistryBuilder.java
      
/Users/jpercivall/projects/nifi/nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/test/java/org/apache/nifi/reporting/datadog/TestDataDogReportingTask.java
      
/Users/jpercivall/projects/nifi/nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/test/java/org/apache/nifi/reporting/datadog/TestMetricsService.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to