[
https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381430#comment-15381430
]
ASF GitHub Bot commented on NIFI-2280:
--------------------------------------
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/664
Looks good overall, a couple of the deprecated markings are missing a
corresponding "@deprecated use other getCipher requiring a salt" javadoc. I'll
just add them for you because everything else looks good.
> Annotate methods as deprecated on 0.x which aren't needed on 1.x
> ----------------------------------------------------------------
>
> Key: NIFI-2280
> URL: https://issues.apache.org/jira/browse/NIFI-2280
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Joseph Witt
> Assignee: Joseph Witt
> Fix For: 0.8.0
>
>
> During the deprecated method removal/cleanup on 1.0 a few methods became no
> longer necessary that weren't deprecated on 0.x.
> So this ticket is to mark them as deprecated on 0.x.
> They are:
> - Encrypt Process interface method for getCipher can be Deprecated. Was
> deprecated in a couple impls. Discussion on NIFI-1157
> - AbstractControllerService 'onConfigurationChange' is no longer needed. Was
> an empty impl and invoked by annotation. Deprecate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
