Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/502#discussion_r71086749
--- Diff: pom.xml ---
@@ -227,6 +227,29 @@ language governing permissions and limitations under
the License. -->
<version>1.5.3-M1</version>
</dependency>
<dependency>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-core</artifactId>
+ <version>1.6.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.ignite</groupId>
+ <artifactId>ignite-spring</artifactId>
+ <version>1.6.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apached.ignite</groupId>
+ <artifactId>ignite-core</artifactId>
+ <version>1.6.0</version>
+ <type>test-jar</type>
+ <scope>test</scope>
--- End diff --
I'd suggest against providing the scope here and instead putting it in the
pom where it's used. Adding the scope test here will propagate to any package
that brings in this dependency (even transitively).
Comment also applies to ignite-log4j2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
