[
https://issues.apache.org/jira/browse/NIFI-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384332#comment-15384332
]
ASF GitHub Bot commented on NIFI-2309:
--------------------------------------
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/672#discussion_r71359806
--- Diff:
nifi-nar-bundles/nifi-ambari-bundle/nifi-ambari-reporting-task/src/main/java/org/apache/nifi/reporting/ambari/metrics/MetricsService.java
---
@@ -46,7 +46,13 @@
metrics.put(MetricNames.BYTES_READ,
String.valueOf(status.getBytesRead()));
metrics.put(MetricNames.BYTES_WRITTEN,
String.valueOf(status.getBytesWritten()));
metrics.put(MetricNames.ACTIVE_THREADS,
String.valueOf(status.getActiveThreadCount()));
- metrics.put(MetricNames.TOTAL_TASK_DURATION,
String.valueOf(calculateProcessingNanos(status)));
+
+ final long durationNanos = calculateProcessingNanos(status);
+ metrics.put(MetricNames.TOTAL_TASK_DURATION_NANOS,
String.valueOf(durationNanos));
+
+ final long durationSeconds =
TimeUnit.SECONDS.convert(durationNanos, TimeUnit.NANOSECONDS);
+ metrics.put(MetricNames.TOTAL_TASK_DURATION_SECONDS,
String.valueOf(durationNanos));
--- End diff --
This uses durationNanos, not durationSeconds
> AmbariReportingTask misleading metric name
> ------------------------------------------
>
> Key: NIFI-2309
> URL: https://issues.apache.org/jira/browse/NIFI-2309
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Minor
> Fix For: 1.0.0
>
>
> The AmbariReportingTask reports "TotalTaskDurationSeconds" but sends the
> value as nano-seconds. Sending nano-seconds is fine, but we should rename the
> metric so it doesn't imply seconds.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
