Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/642#discussion_r71372009
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java
 ---
    @@ -303,8 +303,8 @@ public void onTrigger(ProcessContext context, 
ProcessSession session) throws Pro
                         stateMapProperties.put(fqn, 
Long.toString(System.currentTimeMillis()));
                     }
                 }
    -            // Update the last time the processor finished successfully
    -            stateManager.replace(stateMap, stateMapProperties, 
Scope.CLUSTER);
    +            // Update the timestamps for listed tables
    +            stateManager.setState(stateMapProperties, Scope.CLUSTER);
    --- End diff --
    
    I would not change this to setState. It will overwrite anything that is in 
State. If someone does end up running clustered and not primary Node it will 
blow it away without warnings. 
    
    Instead just check if the prior map version was -1 and do a set instead of 
replace.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to