[ 
https://issues.apache.org/jira/browse/NIFI-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393051#comment-15393051
 ] 

ASF GitHub Bot commented on NIFI-2208:
--------------------------------------

Github user YolandaMDavis commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/571#discussion_r72177525
  
    --- Diff: 
nifi-api/src/test/java/org/apache/nifi/registry/TestVariableRegistry.java ---
    @@ -0,0 +1,160 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.nifi.registry;
    +
    +import java.io.IOException;
    +import java.nio.file.Path;
    +import java.nio.file.Paths;
    +import java.util.HashMap;
    +import java.util.Map;
    +import java.util.Properties;
    +import java.util.Set;
    +
    +import org.junit.Test;
    +
    +import static org.junit.Assert.assertTrue;
    +
    +public class TestVariableRegistry {
    +
    +    @Test
    +    public void testReadMap(){
    +        Map<String,String> variables1 = new HashMap<>();
    +        variables1.put("fake.property.1","fake test value");
    +
    +        Map<String,String> variables2 = new HashMap<>();
    +        variables1.put("fake.property.2","fake test value");
    +
    +        VariableRegistry registry = 
VariableRegistryFactory.getInstance(variables1,variables2);
    +
    +        Map<String,String> variables = registry.getVariables();
    +        assertTrue(variables.size() == 2);
    +        assertTrue(variables.get("fake.property.1").equals("fake test 
value"));
    +        
assertTrue(registry.getVariableValue("fake.property.2").equals("fake test 
value"));
    +    }
    +
    +    @Test
    +    public void testReadProperties(){
    +        Properties properties = new Properties();
    +        properties.setProperty("fake.property.1","fake test value");
    +        VariableRegistry registry = 
VariableRegistryFactory.getPropertiesInstance(properties);
    +        Map<String,String> variables = registry.getVariables();
    +        assertTrue(variables.get("fake.property.1").equals("fake test 
value"));
    +    }
    +
    +    @Test
    +    public void testReadFiles() throws IOException{
    +        final Path fooPath = 
Paths.get("src/test/resources/TestVariableRegistry/foobar.properties");
    --- End diff --
    
    I haven't but can attempt to.


> Support Custom Properties in Expression Language - 1.x baseline
> ---------------------------------------------------------------
>
>                 Key: NIFI-2208
>                 URL: https://issues.apache.org/jira/browse/NIFI-2208
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Yolanda M. Davis
>            Priority: Blocker
>             Fix For: 1.0.0
>
>
> NIFI-1974 addressed this for the 0.x baseline but the PR does not apply 
> cleanly to the 1.x baseline. Creating a separate JIRA for 1.x so that we can 
> close out NIFI-1974 since 0.7.0 is ready to be released.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to