Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/695
I don't really understand the structure of the tool here -- it looks like
`TlsToolkitMain` is invoked from the scripts, and it has an internal instance
of `TlsToolkitCommandLine` to parse the command line arguments, and an instance
of `TlsHelper`. I would expect `TlsToolkitMain` to be a standalone class which
encapsulated the logic (and ideally, to be named something like
`CertificateGeneratorTool` as it is focusing solely on the key and certificate
generation), and `TlsToolkitCommandLine` to be a wrapper class which handles
and parses command line input to then invoke the main class logic. This way,
the logic could be invoked programmatically from other classes with direct
parameter provision. It seems to me that the current structure tightly couples
all certificate generation & keystore population the with command line entry
point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
