Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/688#discussion_r72614233
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat/ClusterProtocolHeartbeatMonitor.java
---
@@ -91,12 +91,8 @@ public ClusterProtocolHeartbeatMonitor(final
ClusterCoordinator clusterCoordinat
this.clusterNodesPath =
zkClientConfig.resolvePath("cluster/nodes");
String hostname =
properties.getProperty(NiFiProperties.CLUSTER_NODE_ADDRESS);
- if (hostname == null) {
- try {
- hostname = InetAddress.getLocalHost().getHostName();
- } catch (UnknownHostException e) {
- throw new RuntimeException("Unable to determine local
hostname and the '" + NiFiProperties.CLUSTER_NODE_ADDRESS + "' property is not
set");
- }
+ if (hostname == null || hostname.trim().isEmpty()) {
--- End diff --
For port, we do validate that the port can be parsed via Integer.parseInt
-- if empty string, that will fail. I guess the error message may be more clear
if we explicitly check for empty string though and indicate that the property
is not specified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
