Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/529#discussion_r72733243
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/StandardRemoteGroupPort.java
 ---
    @@ -366,6 +371,14 @@ private int receiveFlowFiles(final Transaction 
transaction, final ProcessContext
             return flowFilesReceived.size();
         }
     
    +    private String createTransitUri(Transaction transaction, String 
sourceFlowFileIdentifier) {
    +        if (transaction instanceof CustomTransitUriTransaction) {
    --- End diff --
    
    @markap14 Thanks for the comment, I agree with that. I felt that I should 
have kept Peer completely immutable, so I might bypass the createTransitUri 
call to CommunicationsSession. Will update the PR soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to