[
https://issues.apache.org/jira/browse/NIFI-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399417#comment-15399417
]
ASF GitHub Bot commented on NIFI-2419:
--------------------------------------
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/739#discussion_r72802000
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
---
@@ -3279,14 +3256,14 @@ public synchronized void onLeaderElection() {
});
}
+
/**
* Sets whether this instance is clustered. Clustered means that a
node is either connected or trying to connect to the cluster.
*
* @param clustered true if clustered
* @param clusterInstanceId if clustered is true, indicates the
InstanceID of the Cluster Manager
- * @param clusterManagerDn the DN of the NCM
*/
- public void setClustered(final boolean clustered, final String
clusterInstanceId, final String clusterManagerDn) {
+ public void setClustered(final boolean clustered, final String
clusterInstanceId) {
--- End diff --
Given that this is non-public API and is only used by StandardFlowService
do you mind if we make it package private? Don't need to actually do it as I
can do it during merge/squash. Just want your OK.
Basically since we alredy started conversation around annotation private
APIs, annotation is the last resort for cases where native Java compile
constructs can't protect. And I see this as a case. We can always go back to
public if there is justification in the future.
> Node could be elected Cluster Coordinator when disconnected from cluster
> ------------------------------------------------------------------------
>
> Key: NIFI-2419
> URL: https://issues.apache.org/jira/browse/NIFI-2419
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.0.0
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Blocker
> Fix For: 1.0.0
>
>
> In my cluster, I see the following Node events for a particular node:
> 07/28/2016 06:17:29 UTC: Acquired role [Cluster Coordinator]
> 07/28/2016 04:53:30 UTC: Node Status changed from CONNECTING to DISCONNECTED
> due to org.apache.nifi.controller.UninheritableFlowException: Failed to
> connect node to cluster because local flow is different than cluster flow.
> So the Cluster Coordinator role was obtained even though the node is
> disconnected. This shouldn't happen.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
