Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/739#discussion_r72810212
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
---
@@ -3279,14 +3256,14 @@ public synchronized void onLeaderElection() {
});
}
+
/**
* Sets whether this instance is clustered. Clustered means that a
node is either connected or trying to connect to the cluster.
*
* @param clustered true if clustered
* @param clusterInstanceId if clustered is true, indicates the
InstanceID of the Cluster Manager
- * @param clusterManagerDn the DN of the NCM
*/
- public void setClustered(final boolean clustered, final String
clusterInstanceId, final String clusterManagerDn) {
+ public void setClustered(final boolean clustered, final String
clusterInstanceId) {
--- End diff --
@olegz - I think it is accurate that this is called only from other classes
within the same package (I believe only StandardFlowService, in fact). And if
that is the case then yes, I have no problem with making it package-private.
Feel free to do so on merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
